[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

Sat Feb 29 09:58:22 PST 2020

MaskRay added a comment.

In lld, SHT_ARM_ATTRIBUTES sections are deduplicated, thus `test/ELF/arm-attributes.s`. No code deduplicate SHT_RISCV_ATTRIBUTES, thus I still suggest we delete the lld test change.

Landing D75015 <https://reviews.llvm.org/D75015> first can reduce changes in this patch....

================
Comment at: lld/test/ELF/Inputs/riscv-attributes1.s:2
+// Input that generates an object with a populated SHT_RISCV_ATTRIBUTES section.
+.text
+.attribute Tag_stack_align, 16
----------------
`.text` can be deleted

================
Comment at: lld/test/ELF/riscv-attributes.s:43
+_start:
+  .globl func
+  call func
----------------
HsiangKai wrote:
> MaskRay wrote:
> > To disable a missing entry warning:
> > 
> > ```
> > .globl _start
> > _start:
> > ```
> > 
> > is sufficient. 
> I want to call another function `func` located in another file `riscv-attributes1.s`.
`ld.lld %t1.rv32.o %t2.rv32.o` links both object files. It is not necessary to add a `call`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023