[PATCH] D75415: [DAGCombiner] Don't emit select_cc from visitSINT_TO_FP/visitUINT_TO_FP. Use plain select instead.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 29 17:24:28 PST 2020


craig.topper created this revision.
craig.topper added reviewers: spatel, RKSimon.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Select_cc isn't used by all targets. X86 doesn't have optimizations
for it.

Since we already know the input to the sint_to_fp/uint_to_fp is
a setcc we can just emit a plain select using that setcc as the
condition. Other DAG combines can turn that into a select_cc on
targets that support it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75415

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/X86/cmovcmov.ll
  llvm/test/CodeGen/X86/pr44749.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75415.247470.patch
Type: text/x-patch
Size: 7417 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200301/95956bf3/attachment.bin>


More information about the llvm-commits mailing list