[PATCH] D74176: [CMake] Link against ZLIB::ZLIB

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 29 11:10:18 PST 2020


phosek marked 3 inline comments as done.
phosek added inline comments.


================
Comment at: llvm/lib/Support/CMakeLists.txt:198
+  if(NOT zlib_library)
+    get_property(zlib_library TARGET ZLIB::ZLIB PROPERTY LOCATION)
+  endif()
----------------
smeenai wrote:
> I tested locally with CMake 3.4.3, and it looks like `LOCATION` works for reading even on that version, so I'm just gonna assume it also works in subsequent versions :D
I tested it against 3.13.4 so hopefully should be fine in other versions as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74176/new/

https://reviews.llvm.org/D74176





More information about the llvm-commits mailing list