[PATCH] D71916: High-Level Code-Review Documentation Update

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 29 07:53:49 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/docs/CodeReview.rst:217
+on a patch, but patches should be approved only consistent with the policy above.
+
----------------
MaskRay wrote:
> Delete the trailing empty line.
I am still seeing the empty line.


================
Comment at: llvm/docs/CodeReview.rst:230
+  smaller your patch is, the higher the probability that somebody will take a quick
+  look at it. When doing this, it is helpful to add "[N/M]" (for 1 < N < M) to
+  the title of each patch in the series, so it is clear that there is an order
----------------
Is this meant to imply that the first and the final patches in a series should use a different convention?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71916/new/

https://reviews.llvm.org/D71916





More information about the llvm-commits mailing list