[PATCH] D73763: [DSE] Lift post-dominance restriction.

Tyker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 29 05:13:18 PST 2020


Tyker added a comment.

this seems like a great approach to me.



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1596
 
   // Find a MemoryDef writing to \p DefLoc and dominating \p Current, with no
   // read access in between or return None otherwise. The returned value may not
----------------
the comment seems outdated.
i think that with this patch dominating will not be true anymore.
and MemoryPHI seems to not cause a bail out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73763/new/

https://reviews.llvm.org/D73763





More information about the llvm-commits mailing list