[PATCH] D75082: [ExecutionEngine] Add JITSymbolFlags::fromSummary(GlobalValueSummary*)

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 29 04:02:10 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGec1e7faf65ae: [ExecutionEngine] Add JITSymbolFlags::fromSummary(GlobalValueSummary*) (authored by sgraenitz).

Changed prior to commit:
  https://reviews.llvm.org/D75082?vs=246311&id=247436#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75082/new/

https://reviews.llvm.org/D75082

Files:
  llvm/include/llvm/ExecutionEngine/JITSymbol.h
  llvm/lib/ExecutionEngine/RuntimeDyld/JITSymbol.cpp


Index: llvm/lib/ExecutionEngine/RuntimeDyld/JITSymbol.cpp
===================================================================
--- llvm/lib/ExecutionEngine/RuntimeDyld/JITSymbol.cpp
+++ llvm/lib/ExecutionEngine/RuntimeDyld/JITSymbol.cpp
@@ -14,6 +14,7 @@
 #include "llvm/IR/Function.h"
 #include "llvm/IR/GlobalAlias.h"
 #include "llvm/IR/GlobalValue.h"
+#include "llvm/IR/ModuleSummaryIndex.h"
 #include "llvm/Object/ObjectFile.h"
 
 using namespace llvm;
@@ -36,6 +37,22 @@
   return Flags;
 }
 
+JITSymbolFlags llvm::JITSymbolFlags::fromSummary(GlobalValueSummary *S) {
+  JITSymbolFlags Flags = JITSymbolFlags::None;
+  auto L = S->linkage();
+  if (GlobalValue::isWeakLinkage(L) || GlobalValue::isLinkOnceLinkage(L))
+    Flags |= JITSymbolFlags::Weak;
+  if (GlobalValue::isCommonLinkage(L))
+    Flags |= JITSymbolFlags::Common;
+  if (GlobalValue::isExternalLinkage(L) || GlobalValue::isExternalWeakLinkage(L))
+    Flags |= JITSymbolFlags::Exported;
+
+  if (isa<FunctionSummary>(S))
+    Flags |= JITSymbolFlags::Callable;
+
+  return Flags;
+}
+
 Expected<JITSymbolFlags>
 llvm::JITSymbolFlags::fromObjectSymbol(const object::SymbolRef &Symbol) {
   JITSymbolFlags Flags = JITSymbolFlags::None;
Index: llvm/include/llvm/ExecutionEngine/JITSymbol.h
===================================================================
--- llvm/include/llvm/ExecutionEngine/JITSymbol.h
+++ llvm/include/llvm/ExecutionEngine/JITSymbol.h
@@ -30,6 +30,7 @@
 namespace llvm {
 
 class GlobalValue;
+class GlobalValueSummary;
 
 namespace object {
 
@@ -160,6 +161,10 @@
   /// value.
   static JITSymbolFlags fromGlobalValue(const GlobalValue &GV);
 
+  /// Construct a JITSymbolFlags value based on the flags of the given global
+  /// value summary.
+  static JITSymbolFlags fromSummary(GlobalValueSummary *S);
+
   /// Construct a JITSymbolFlags value based on the flags of the given libobject
   /// symbol.
   static Expected<JITSymbolFlags>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75082.247436.patch
Type: text/x-patch
Size: 1933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200229/fb8aca80/attachment.bin>


More information about the llvm-commits mailing list