[PATCH] D75341: [BFI] Use CallbackVH to notify BFI about deletion of basic blocks

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 21:15:36 PST 2020


DaniilSuchkov added a comment.

In D75341#1899307 <https://reviews.llvm.org/D75341#1899307>, @davidxl wrote:

> Do you mean it does not work well for const pointers? There are existing uses of AssertingVH<const BasicBlock> or AssertingVH<const Value>?


Actually you're right, thank you!
It didn't cross my mind that someone could've already included const_casts into AssertingVH itself, so that unlike other ValueHandles it accepts const pointers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75341/new/

https://reviews.llvm.org/D75341





More information about the llvm-commits mailing list