[PATCH] D75390: Fix GSYM tests to run the yaml files and fix test failures on some machines.
Greg Clayton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 28 17:28:20 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd334ce0b5acb: Fix GSYM tests to run the yaml files and fix test failures on some machines. (authored by clayborg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75390/new/
https://reviews.llvm.org/D75390
Files:
llvm/test/tools/llvm-gsymutil/lit.local.cfg
llvm/tools/llvm-gsym/llvm-gsymutil.cpp
Index: llvm/tools/llvm-gsym/llvm-gsymutil.cpp
===================================================================
--- llvm/tools/llvm-gsym/llvm-gsymutil.cpp
+++ llvm/tools/llvm-gsym/llvm-gsymutil.cpp
@@ -179,7 +179,8 @@
if (ArchFilters.empty())
return true;
- StringRef ObjArch = Obj.getArchTriple().getArchName();
+ Triple ObjTriple(Obj.getArchTriple());
+ StringRef ObjArch = ObjTriple.getArchName();
for (auto Arch : ArchFilters) {
// Match name.
@@ -350,7 +351,8 @@
error(Filename, errorToErrorCode(BinOrErr.takeError()));
if (auto *Obj = dyn_cast<ObjectFile>(BinOrErr->get())) {
- auto ArchName = Obj->makeTriple().getArchName();
+ Triple ObjTriple(Obj->makeTriple());
+ auto ArchName = ObjTriple.getArchName();
outs() << "Output file (" << ArchName << "): " << OutFile << "\n";
if (auto Err = handleObjectFile(*Obj, OutFile.c_str()))
return Err;
@@ -374,7 +376,8 @@
// Now handle each architecture we need to convert.
for (auto &Obj: FilterObjs) {
- auto ArchName = Obj->getArchTriple().getArchName();
+ Triple ObjTriple(Obj->getArchTriple());
+ auto ArchName = ObjTriple.getArchName();
std::string ArchOutFile(OutFile);
// If we are only handling a single architecture, then we will use the
// normal output file. If we are handling multiple architectures append
Index: llvm/test/tools/llvm-gsymutil/lit.local.cfg
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-gsymutil/lit.local.cfg
@@ -0,0 +1 @@
+config.suffixes = ['.test', '.yaml']
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75390.247391.patch
Type: text/x-patch
Size: 1608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200229/e34cc212/attachment.bin>
More information about the llvm-commits
mailing list