[PATCH] D75301: [ADT] Allow K to be incomplete during DenseMap<K*, V> instantiation

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 12:30:03 PST 2020


rnk added a comment.

Yes, DenseMap already asserts if you try to lookup or insert the two sentinel keys. My comment had more to do with -4096 being a more plausible pointer value than -16/-8, so we are marginally more likely to hit that assert, maybe in a kernel context, like opencl drivers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75301/new/

https://reviews.llvm.org/D75301





More information about the llvm-commits mailing list