[PATCH] D75213: RFC: More principled implementation of DISubprogram::describes()

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D75213#1898320 <https://reviews.llvm.org/D75213#1898320>, @aprantl wrote:

> I'm inclined to try to commit this and see if we get any "describes" assertion reports.


SGTM.



================
Comment at: llvm/lib/IR/Verifier.cpp:2397
 
     // FIXME: Once N is canonical, check "SP == &N".
     AssertDI(SP->describes(&F),
----------------
Should this FIXME be updated?


================
Comment at: llvm/lib/IR/Verifier.cpp:2401
              &I, DL, Scope, SP);
-    visitMDNode(*SP);
   };
----------------
It's not obvious to me why this call is no longer necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75213/new/

https://reviews.llvm.org/D75213