[PATCH] D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/X86/call-site-info-mov16ri.mir:85
+  !29 = !DIDerivedType(tag: DW_TAG_typedef, name: "a", file: !7, line: 1, baseType: !10)
+  !30 = !DILocalVariable(name: "o", scope: !23, file: !7, line: 18, type: !31)
+  !31 = !DIDerivedType(tag: DW_TAG_typedef, name: "b", file: !7, line: 2, baseType: !10)
----------------
I'm pretty sure there is a bunch of unnecessary debug info in this test. Do we need more than one local variable?


================
Comment at: llvm/test/DebugInfo/MIR/X86/call-site-info-mov16ri.mir:95
+  !39 = !{!40, !40, i64 0}
+  !40 = !{!"any pointer", !35, i64 0}
+  !41 = !DILocalVariable(name: "buffer", arg: 1, scope: !42, type: !45, flags: DIFlagArtificial)
----------------
Do we need the TBAA info?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75326/new/

https://reviews.llvm.org/D75326