[PATCH] D74819: [DebugInfo] Report unsupported maximum_operations_per_instruction values

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:928
+      public AdjustAddressFixtureBase {
+  void SetUp() {
+    std::tie(Version, MaxOpsPerInst, IsErrorExpected) = GetParam();
----------------
jhenderson wrote:
> ikudrin wrote:
> > Yet another warning:
> > ```
> > DWARFDebugLineTest.cpp:928:8: warning: 'SetUp' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> > ```
> > The similar warnings are also shown for `SetUp` methods in the dependent patches.
> Does this `SetUp` warning also apply for the `DebugLineParameterisedFixture` or `DebugLineUnsupportedVersionFixture` classes? They aren't new, but are missing `override`s on their `SetUp` functions.
Nope. The warning appears if //some// methods in a class are missing `override`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74819/new/

https://reviews.llvm.org/D74819