[PATCH] D75290: [SystemZ] Also accept ISD::USUBO in shouldFormOverflowOp()
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 28 05:00:00 PST 2020
uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.
Otherwise, LGTM. Thanks!
================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.h:444
bool shouldFormOverflowOp(unsigned Opcode, EVT VT,
- bool MathUsed) const override {
- // Using overflow ops for overflow checks only should beneficial on
- // SystemZ.
- return TargetLowering::shouldFormOverflowOp(Opcode, VT, true);
- }
+ bool MathUsed) const override;
----------------
Why do you move it to the .cpp file? It still seems small enough to usefully inline ...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75290/new/
https://reviews.llvm.org/D75290
More information about the llvm-commits
mailing list