[PATCH] D75250: [DebugInfo] Add unit test for compact expression printer
Oliver Stannard (Linaro) via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 28 02:58:21 PST 2020
ostannard marked 4 inline comments as done.
ostannard added inline comments.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFExpressionCompactPrinterTest.cpp:27
+public:
+ std::unique_ptr<MCRegisterInfo> MRI;
+
----------------
jhenderson wrote:
> As this is a brand new file, and is completely local in scope (i.e. doesn't get used by anything else), perhaps we should apply the planned new variable naming rules of lower camel-case for variable names (e.g. `mri`, `tripleName` etc)? What do you think?
>
> I'm okay with it either way.
I'd prefer to keep the style consistent with the nearby files until we switch over to the new rule.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75250/new/
https://reviews.llvm.org/D75250
More information about the llvm-commits
mailing list