[PATCH] D75234: [LLD] Report errors occurred while parsing debug info as warnings.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/test/ELF/gdb-index-invalid-ranges.s:8-9
 
-# CHECK: ld.lld: error: {{.*}}gdb-index-invalid-ranges.s.tmp.o:(.debug_info): decoding address ranges: invalid range list entry at offset 0x10
-# ARCHIVE: ld.lld: error: {{.*}}gdb-index-invalid-ranges.s.tmp.a(gdb-index-invalid-ranges.s.tmp.o):(.debug_info): decoding address ranges: invalid range list entry at offset 0x10
+# CHECK: ld.lld: warning: {{.*}}gdb-index-invalid-ranges.s.tmp.o:{{(\(\.debug_info\):)?}} decoding address ranges: invalid range list entry at offset 0x10
+# ARCHIVE: ld.lld: warning: {{.*}}gdb-index-invalid-ranges.s.tmp.a(gdb-index-invalid-ranges.s.tmp.o):{{(\(\.debug_info\):)?}} decoding address ranges: invalid range list entry at offset 0x10
 
----------------
Same comments as in the other test - why has the text changed in this patch when all you've done is change the severity of this error?


================
Comment at: lld/test/ELF/gdb-index-parse-fail.s:5
 
-# CHECK: error: {{.*}}:(.debug_info): invalid reference to or invalid content in .debug_str_offsets[.dwo]: insufficient space for 32 bit header prefix
+# CHECK: warning: {{.*}}:{{(\(\.debug_info\):)?}} invalid reference to or invalid content in .debug_str_offsets[.dwo]: insufficient space for 32 bit header prefix
 
----------------
avl wrote:
> MaskRay wrote:
> > Why the `?` metacharacter?
> To have one or zero "(.debug_info):". Please check that description https://reviews.llvm.org/D74773#inline-683778
But isn't in this patch this output unchanged from before? The only change in the text should be error -> warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75234/new/

https://reviews.llvm.org/D75234