[PATCH] D75123: [obj2yaml, yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 01:04:34 PST 2020


grimar added a comment.

In D75123#1896131 <https://reviews.llvm.org/D75123#1896131>, @MaskRay wrote:

> How about the following plan?
>
> 1. This patch: supporting both `[0,1]` and `"3031"` (hex pairs) in yaml2obj. Support `[0x00, 0x01]` in obj2yaml. Only obj2yaml tests need to be updated. There are only a few.
> 2. A future change: change `"3031"` (hex pairs) to `"01"` (strings) in yaml2obj. ~180 tests need to be migrated. This can probably be done mechanically with a dedicated tool.


I did not understand it I think.
Currectly we support hex pairs, like "00112233". This patch suggests "`[0x00, 0x01]`" instead. Not sure I understand what do you mean by "strings" in (2)? I.e. what is the difference with "pairs" we have?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75123/new/

https://reviews.llvm.org/D75123





More information about the llvm-commits mailing list