[PATCH] D74904: [CallSiteInfo] Handle bundles when updating call site info

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 00:02:00 PST 2020


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchFolding.cpp:173
   std::for_each(MBB->begin(), MBB->end(), [MF](const MachineInstr &MI) {
-    if (MI.isCandidateForCallSiteEntry())
+    if (MI.shouldUpdateCallSiteInfo())
       MF->eraseCallSiteInfo(&MI);
----------------
aprantl wrote:
> drive-by comment: Should there be a 
> 
> ```
> MachineInstruction::eraseStaleCallSiteInfo() {
>   if (shouldUpdateCallSiteInfo())
>     getFunction()->eraseCallSiteInfo(&MI);
> }
> ```
> 
> helper?
I think that makes sense, that can go as an NFC?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74904/new/

https://reviews.llvm.org/D74904





More information about the llvm-commits mailing list