[PATCH] D75268: A light-weight solution to align branches within 32B boundary by prefix padding

[Kan Shengchen via Phabricator via llvm-commits]

skan marked 2 inline comments as done.
skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:385
+  // Currently don't deal with Bundle cases.
+  if (OS.getAssembler().isBundlingEnabled())
     return false;
----------------
reames wrote:
> This looks like a potentially unrelated change.  Can it be separated?
Okay


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:493
+  case X86::CS:
+    return 0x2e;
+  case X86::SS:
----------------
reames wrote:
> Please replace constants with X86::CS_PREFIX and friends.
X86::CS_PREFIX is a enum value and used to represent the instruction is a cs prefix indeed. Constants 0x2e is the encoding value for X86::CS, thery are different. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75268/new/

https://reviews.llvm.org/D75268