[PATCH] D75291: Rename "llvm-gsym" and "llvm-gsymutil" to "gsymutil".

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 16:29:20 PST 2020


clayborg marked 2 inline comments as done.
clayborg added inline comments.


================
Comment at: llvm/tools/gsymutil/gsymutil.cpp:432
   llvm::InitializeAllTargetInfos();
   llvm::InitializeAllTargetMCs();
   llvm::InitializeAllTargets();
----------------
MaskRay wrote:
> Can you recheck whether the remaining are all needed?
If I removed all InitializeAllTargetInfos and InitializeAllTargetMCs I got errors when trying to load object files. I didn't try them individually though, so I will try that. 


================
Comment at: llvm/tools/gsymutil/gsymutil.cpp:434
   llvm::InitializeAllTargets();
-  llvm::InitializeAllAsmPrinters();
 
   const char *Overview =
----------------
aprantl wrote:
> This is not a rename?
Yeah, I modified the description after submitting to say "Also removed the AsmPrinter from the dependencies.". 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75291/new/

https://reviews.llvm.org/D75291





More information about the llvm-commits mailing list