[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/riscv-attributes.s:1
+# REQUIRES: riscv
+
----------------
I suggest not making changes to `lld/test/ELF` for this patch. The changes can be made in a follow-up patch.


================
Comment at: lld/test/ELF/riscv-attributes.s:3
+
+# RUN: llvm-mc -filetype=obj -triple=riscv32-unknown-elf %S/Inputs/riscv-attributes1.s -o %t1.rv32.o
+# RUN: llvm-mc -filetype=obj -triple=riscv64-unknown-elf %S/Inputs/riscv-attributes1.s -o %t1.rv64.o
----------------
Remove `-unknown-elf`


================
Comment at: lld/test/ELF/riscv-attributes.s:43
+_start:
+  .globl func
+  call func
----------------
To disable a missing entry warning:

```
.globl _start
_start:
```

is sufficient. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023