[PATCH] D75296: [SLP][NFC] Assert that tree entry operands completed when scheduler looks for dependencies.

Thu Feb 27 13:32:23 PST 2020

ABataev added a comment.

In D75296#1896654 <https://reviews.llvm.org/D75296#1896654>, @vdmitrie wrote:

> In D75296#1896620 <https://reviews.llvm.org/D75296#1896620>, @ABataev wrote:
>
> > Maybe it is better to implement the two-steps approach? If it may lead to a crash, it will definitely cause a crash somewhere
>
>
> I'm not sure I got your question. The two steps approach is what is implemented and used at the moment. Example in the summary shows situation leading to firing the assertion.

SO, we have correct implementation and this is just a check to prevent possible bugs in the future?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75296/new/

https://reviews.llvm.org/D75296