[PATCH] D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.
Herald added a subscriber: ormris.

You may be able to run delta on the MIR testcases.



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.h:108
 
+  Optional<ParamLoadedValue> describeLoadedValue(const MachineInstr &MI,
+                                                 Register Reg) const override;
----------------
doxygen comment?


================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovd.mir:46
+  
+  attributes #0 = { nounwind optsize uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="cortex-m4" "target-features"="+armv7e-m,+dsp,+fp16,+fpregs,+hwdiv,+strict-align,+thumb-mode,+vfp2sp,+vfp3d16sp,+vfp4d16sp" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  attributes #1 = { optsize "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="cortex-m4" "target-features"="+armv7e-m,+dsp,+fp16,+fpregs,+hwdiv,+strict-align,+thumb-mode,+vfp2sp,+vfp3d16sp,+vfp4d16sp" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
we probably don't need most of these?


================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovs.mir:38
+  
+  attributes #0 = { nounwind optsize uwtable "disable-tail-calls"="false" "frame-pointer"="all" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "target-cpu"="cortex-m4" "target-features"="+armv7e-m,+dsp,+fp16,+fpregs,+hwdiv,+strict-align,+thumb-mode,+vfp2sp,+vfp3d16sp,+vfp4d16sp" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  attributes #1 = { optsize "disable-tail-calls"="false" "frame-pointer"="all" "target-cpu"="cortex-m4" "target-features"="+armv7e-m,+dsp,+fp16,+fpregs,+hwdiv,+strict-align,+thumb-mode,+vfp2sp,+vfp3d16sp,+vfp4d16sp" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
or these?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75273/new/

https://reviews.llvm.org/D75273