[PATCH] D74162: [Inliner] Inlining should honor nobuiltin attributes

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:267
+  /// attributes, which is conservatively correct.
+  bool areInlineCompatible(const TargetLibraryInfo &CalleeTLI) const {
+    BitVector B = OverrideAsUnavailable;
----------------
This may be bad for performance -- as the inline instance will be optimized differently.


================
Comment at: llvm/test/Transforms/Inline/X86/inline-no-builtin-compatible.ll:6
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
Is this test x86 specific?


================
Comment at: llvm/test/Transforms/Inline/X86/inline-no-builtin-compatible.ll:23
+  ret i32 %call
+; CHECK-LABEL: nobuiltinmemcpy
+; CHECK: call i32 (...) @externalfunc()
----------------
why not directly check-not call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74162/new/

https://reviews.llvm.org/D74162