[PATCH] D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections.

.dynstr => allocatable SHT_STRTAB
.dynsym => SHT_DYNSYM

I haven't seen a case for allocatable SHT_SYMTAB but due to how the switch cases are organized, I think it does not hurt to place SHT_SYMTAB there.

Non-allocatable SHT_STRTAB and SHT_SYMTAB and usually in the end of the file. Their presence changes offsets of themselves and the section header table. Making them implicit seems fine.

With this scheme, a new option will not be needed. I am in favor of such a change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74955/new/

https://reviews.llvm.org/D74955