[PATCH] D75267: [AMDGPU] improve fragile test for divergent branches

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/divergent-branch-uniform-condition.ll:8
+; not its condition, so that branch is correctly emitted as divergent.
 
 target triple = "amdgcn-mesa-mesa3d"
----------------
sameerds wrote:
> arsenm wrote:
> > I think this should include ISA generated checks, and we should probably just generate checks for all control flow tests 
> I am not sure I understand what you mean. Do you want ISA checks in addition to the checks that I am proposing? Also, what is the set of "all control flow tests"?
Yes. I mean in general we should just generate checks for any control flow test, which this is one of


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75267/new/

https://reviews.llvm.org/D75267