[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:342
+enum DebugVarsFormat {
+  DV_Disabled,
+  DV_Unicode,
----------------
I don't have a strong opinion on this, but perhaps DVDisabled etc would be more in keeping with LLVM style?


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:610-612
+    Column()
+        : VarIdx(NullVarIdx), LiveIn(false), LiveOut(false),
+          MustDrawLabel(false){};
----------------
Could you avoid the constructor entirely and initialise the values inline?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720