[PATCH] D75116: [DWARFDebugLine] Use new DWARFDataExtractor::getInitialLength

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 07:02:15 PST 2020


labath added a comment.

In D75116#1895025 <https://reviews.llvm.org/D75116#1895025>, @jhenderson wrote:

> I had another thought about the "unexpected end of data" message: would it be possible to include the offset at which the data ended? That would still give sufficient context to the message without the need to check in lots of different places.


Yes, that is definitely possible In fact. I was considering that myself but I wasn't sure whether this extra information would be useful.

Now that I think about, I think this is a good idea, particularly once we have truncated data extractors, as then the value will not just be the end of the section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75116/new/

https://reviews.llvm.org/D75116





More information about the llvm-commits mailing list