[PATCH] D75247: [mlir] fix wrong symbol order in AffineApplyNormalizer

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 05:56:15 PST 2020


nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

Thanks for tracking this down Alex!

Note that a lot of the complexity of AffineApplyNormalizer comes from its supporting chain of affine applies and I strongly advocated for being unnecessary cognitive overhead.
We had a window of opportunity to clean all this up about 1 year ago but it got a lot of pushback for very bad reasons (e.g. a few tests with single affine_apply and composed maps would have been more complex).
Are we now in a position were we could say that chains of ops with affine map composition are outlawed so we could simplify this logic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75247/new/

https://reviews.llvm.org/D75247





More information about the llvm-commits mailing list