[PATCH] D75216: [lld][ELF] Add some release notes

[Peter Smith via Phabricator via llvm-commits]

psmith added a comment.

Thanks for taking the lead on this. I've put a few suggestions for some cosmetic changes.



================
Comment at: lld/docs/ReleaseNotes.rst:38
   relocation.
-
-* Reduced size of linked MIPS binaries.
+* For certain "undefined symbol" errors, a definition of a close spelling will be suggested.
+  (`D67039 <https://reviews.llvm.org/D67039>`_)
----------------
grimar wrote:
> Seems you're missing empty lines between improvements.
I suggest "with a" rather than "of a".
For certain "undefined symbol" errors, a definition with a close spelling will be suggested.


================
Comment at: lld/docs/ReleaseNotes.rst:45
+  ``-z noseparate-code`` is the default, which can reduce sizes of linked binaries by up to
+  3 maxpagesize.
+  (`D64903 <https://reviews.llvm.org/D64903>`_ `D67481 <https://reviews.llvm.org/D67481>`_)
----------------
I suggest "3 times maxpagesize." as 3 maxpagesizes isn't the name of an option.


================
Comment at: lld/docs/ReleaseNotes.rst:53
+  (`D59780 <https://reviews.llvm.org/D59780>`_)
+* ``PT_GNU_PROPERTY`` is added to help loaders locate the ``.note.gnu.property`` section.
+  It may be used by a future Linux kernel.
----------------
MaskRay wrote:
> @psmith Maybe you can find ARM contacts who are concerned about this matter.
> I believe `PT_GNU_PROPERTY` in binutils/glibc is not going well. https://sourceware.org/ml/binutils/2020-02/msg00512.html
Thanks for pointing that out. The request to add PT_GNU_PROPERTY came from the Android team as the kernel required PT_GNU_PROPERTY. I'll mention it to them.


================
Comment at: lld/docs/ReleaseNotes.rst:65
+  (`D70658 <https://reviews.llvm.org/D70658>`_)
+* Range extension thunks with addens are implemented for AArch64, PowerPC32 and PowerPC64.
+  (`D70637 <https://reviews.llvm.org/D70637>`_ `D70937 <https://reviews.llvm.org/D70937>`_
----------------
atanasyan wrote:
> MaskRay wrote:
> > > Range extension thunks with addens are implemented for AArch64, PowerPC32 and PowerPC64.
> > 
> > @atanasyan It'd be nice to fix this for MIPS as well, or make it clear that MIPS does not need it.
> MIPS does not use range extension thunks.
typo: "with addends"


================
Comment at: lld/docs/ReleaseNotes.rst:71
+  (`D71820 <https://reviews.llvm.org/D71820>`_)
+* The ARM port will not insert interworking thunks for non STT_FUNC symbols.
+  (`D73474 <https://reviews.llvm.org/D73474>`_)
----------------
Suggest no longer, as it more strongly implies a change.
The ARM port will no longer insert interworking thunks for non STT_FUNC symbols.


================
Comment at: lld/docs/ReleaseNotes.rst:73
+  (`D73474 <https://reviews.llvm.org/D73474>`_)
+* The quality of PowerPC32 port has been greatly improved (canonical PLT, copy
+  relocations, non-preemptible IFUNC, range extension thunks with addends).
----------------
Insert 
* The ARM port will no longer interwork via changing a BL to a BLX for non STT_FUNC symbols. A warning will be given if this results in a change from previous LLD releases.
(`D73542 <https://reviews.llvm.org/D73542`_)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75216/new/

https://reviews.llvm.org/D75216