[PATCH] D75187: [AMDGPU][ConstantFolding] Fold llvm.amdgcn.cube* intrinsics

[Jay Foad via Phabricator via llvm-commits]

foad marked 5 inline comments as done.
foad added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:2317-2320
+  auto GreaterEqual = [](APFloat A, APFloat B) -> bool {
+    APFloat::cmpResult Res = A.compare(B);
+    return Res == APFloat::cmpGreaterThan || Res == APFloat::cmpEqual;
+  };
----------------
arsenm wrote:
> This can use const references and can be moved to a separate function since there's no local captures
I moved it to APFloat::operator>= instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75187/new/

https://reviews.llvm.org/D75187