[PATCH] D74819: [DebugInfo] Report unsupported maximum_operations_per_instruction values

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:752
 
+struct AdjustAddressFixtureBase : public CommonFixture {
+  // Create and update the prologue as specified by the subclass, then return
----------------
`clang-9` shows a warning here:
```
DWARFDebugLineTest.cpp:752:8: warning: '(anonymous namespace)::AdjustAddressFixtureBase' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
```


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:928
+      public AdjustAddressFixtureBase {
+  void SetUp() {
+    std::tie(Version, MaxOpsPerInst, IsErrorExpected) = GetParam();
----------------
Yet another warning:
```
DWARFDebugLineTest.cpp:928:8: warning: 'SetUp' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
```
The similar warnings are also shown for `SetUp` methods in the dependent patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74819/new/

https://reviews.llvm.org/D74819