[PATCH] D75177: [DebugInfo] Avoid a crash when parsing an invalid unit header in DWP.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 02:15:29 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. Just wondering, did you consider writing a unittest instead?



================
Comment at: llvm/test/DebugInfo/X86/invalid-cu-length-dwp.s:54
+    .long 3                     # DW_SECT_ABBREV
+# Row 1:
+    .long .LCUBegin-.debug_info.dwo     # Offset in .debug_info.dwo
----------------
Nit: ##


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75177/new/

https://reviews.llvm.org/D75177





More information about the llvm-commits mailing list