[PATCH] D74955: [obj2yaml] - Dump SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D74955#1894987 <https://reviews.llvm.org/D74955#1894987>, @jhenderson wrote:

> Okay, you make a fair amount of sense. I don't think a switch is necessarily needed. That being said, perhaps we could limit this to the dynamic symbol table and dynamic string table? I feel like .symtab and the non-dynamic string table(s) do not need printing, since they will normally be at the end, don't have addresses, and will just cause unnecessary noise if in the YAML.


I think it is fine, I've also though about such possibility and during work on another patch also realized that dumping just allocatable sections is enough at least for my current use cases.

> I think you'll find the number of tests impacted will subsequently reduce significantly. Perhaps then a switch (e.g. --explicit-symtab-strtab) would be wise to enable dumping these sections. What do you think?

Sounds good to me too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74955/new/

https://reviews.llvm.org/D74955