[PATCH] D74904: [CallSiteInfo] Handle bundles when updating call site info

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 01:18:10 PST 2020


dstenb accepted this revision.
dstenb added a comment.

In D74904#1894898 <https://reviews.llvm.org/D74904#1894898>, @djtodoro wrote:

> In D74904#1893729 <https://reviews.llvm.org/D74904#1893729>, @dstenb wrote:
>
> > Does that patch make this one redundant, or can we land in the cases that this patch fixes with -O>0?
>
>
> This patch fixes the problem and we need it for sure. But, the D75175 <https://reviews.llvm.org/D75175> is another idea (nothing to do with this patch) to avoid production of call site info in the case of non-debug builds, which makes sense to me, since it is being used only for Debug Entry Values feature, but we can move the discussion to that patch.


Okay, thanks for the explanation!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74904/new/

https://reviews.llvm.org/D74904





More information about the llvm-commits mailing list