[PATCH] D75216: [lld][ELF] Add some release notes

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 00:21:38 PST 2020


atanasyan added inline comments.


================
Comment at: lld/docs/ReleaseNotes.rst:39
-
-* Reduced size of linked MIPS binaries.
 
----------------
MaskRay wrote:
> atanasyan wrote:
> > Why did you remove this line?
> IIUC, you meant https://reviews.llvm.org/rL371554.
> 
> But this size optimization is generic. It also removes upto 3*maxpagesize for other targets.
> 
> For example, defaultMaxPageSize is also 65536 on AArch64/powerpc32/powerpc64.
I agree that this change is generic. Does it make a sense to mention about it in the release notes in a generic form?


================
Comment at: lld/docs/ReleaseNotes.rst:65
+  (`D70658 <https://reviews.llvm.org/D70658>`_)
+* Range extension thunks with addens are implemented for AArch64, PowerPC32 and PowerPC64.
+  (`D70637 <https://reviews.llvm.org/D70637>`_ `D70937 <https://reviews.llvm.org/D70937>`_
----------------
MaskRay wrote:
> > Range extension thunks with addens are implemented for AArch64, PowerPC32 and PowerPC64.
> 
> @atanasyan It'd be nice to fix this for MIPS as well, or make it clear that MIPS does not need it.
MIPS does not use range extension thunks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75216/new/

https://reviews.llvm.org/D75216





More information about the llvm-commits mailing list