[PATCH] D75224: [SelectionDAG][FPEnv] Take into account SelectionDAG continuous CSE when setting the nofpexcept flag for constrained intrinsics

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 20:04:05 PST 2020


pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1137
-        Flags.setNoFPExcept(true);
-        Node->setFlags(Flags);
-      }
----------------
Can we just use below code here:
```
SDNodeFlags IncomingFlags;
IncomingFlags.setNoFPExcept(true);
if (!Node->getFlags().isDefined())
  Node->setFlags(IncomingFlags);
else
  Node->intersectFlagsWith(IncomingFlags);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75224/new/

https://reviews.llvm.org/D75224





More information about the llvm-commits mailing list