[PATCH] D75217: [mlir] NFC - Move runner utils from mlir-cpu-runner to tools

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 17:22:04 PST 2020


mehdi_amini added inline comments.


================
Comment at: mlir/tools/mlir-runner-utils/CMakeLists.txt:6
+add_llvm_library(mlir-runner-utils SHARED mlir-runner-utils.cpp)
+target_compile_definitions(mlir-runner-utils PRIVATE mlir-runner-utils_EXPORTS)
----------------
The `tools` directory isn't usually for exposing "libraries" but for exposing command line... tools?

Will this trigger the installation of a `mlir-runner-utils` library for example?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75217/new/

https://reviews.llvm.org/D75217





More information about the llvm-commits mailing list