[PATCH] D68414: [SROA] Enhance AggLoadStoreRewriter to rewrite integer load/store if it covers multi fields in original aggregate

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 15:51:25 PST 2020


Carrot added inline comments.


================
Comment at: test/Transforms/SROA/split-integer.ll:15
+
+define i64 @foo() {
+  %1 = alloca %"struct.std::__u::__tuple_impl", align 8
----------------
arsenm wrote:
> Test should be smaller, check more, and use named values
Test is simplified.
The IR after SROA is quite redundant, they will soon be cleaned up by following passes. And future enhancement of SROA can also change them, so the IR after SROA is not very reliable, other IR changes is not a regression when there is no alloca/store/load.
So I prefer to check alloca/store/load only.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68414/new/

https://reviews.llvm.org/D68414





More information about the llvm-commits mailing list