[PATCH] D71845: [AIX][XCOFF] add test for raw text section content and test section header and Fixed a bug of XCOFFObjectWriter.cpp

Wed Feb 26 15:24:34 PST 2020

hubert.reinterpretcast added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-return55.ll:36
+;CHECKSECT-NEXT:     PhysicalAddress: 0x8
+;CHECKSECT-NEXT:     VirtualAddress: 0x8
+;CHECKSECT-NEXT:     Size: 0xC
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > One of the aspects of the code added, which is still in need to testing, is the possible adjustment of the virtual address such that there is a gap between the end virtual address of one section and the beginning virtual address of the next. This test does not exhibit that.
> The size of the first section is 0x18 starting at address 0x0. The virtual address of the following section is 0x18. I am not seeing how the virtual address adjustment is demonstrated here.
Thanks. My concern here is addressed; however, the patch has changed scope since the previous approval by @daltenty, so new approvals are needed. I also suggest to make the title of this patch describe the bug fix more than the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71845/new/

https://reviews.llvm.org/D71845