[PATCH] D75213: RFC: More principled implementation of DISubprogram::describes()

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

If you're worried about LTO, I suggest trying a clang bootstrap with each of `-flto=full` and `-flto=thin`.  I was using the former as a testcase when I was doing this work, so I think we'd get good signal from that.



================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:663
   assert(F && "Invalid function");
-  if (F->getSubprogram() == this)
-    return true;
-  StringRef Name = getLinkageName();
-  if (Name.empty())
-    Name = getName();
-  return F->getName() == Name;
+  return (F->getSubprogram() == this);
 }
----------------
Nitpick, I think we usually leave the redundant parens off for `return` statements.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75213/new/

https://reviews.llvm.org/D75213