[PATCH] D74883: Add a llvm-gsymutil tool that can convert object files to GSYM and perform lookups.

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked an inline comment as done.
clayborg added a comment.

In D74883#1893219 <https://reviews.llvm.org/D74883#1893219>, @thakis wrote:

> Could we either rename the binary to llvm-gsym or the directory housing it to llvm-gsymutil, so that they match?


I will do a follow up patch once builtbots are happy. Thanks for the comments.



================
Comment at: llvm/tools/llvm-gsym/CMakeLists.txt:7
+  AllTargetsDescs
+  AllTargetsInfos
+  MC
----------------
thakis wrote:
> Finally, since you have ${LLVM_TARGETS_TO_BUILD} already, you don't need to list AllTargetsDescs / AllTargetsInfos – LLVM_TARGETS_TO_BUILD includes those already. (But if you can change your code to not need LLVM_TARGETS_TO_BUILD then it's better to depend on only the Descs and Infos instead, since then less code needs to be linked into llvm-gsymutil.)
Ok, will do follow up patch for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74883/new/

https://reviews.llvm.org/D74883