[PATCH] D74904: [CallSiteInfo] Handle bundles when updating call site info

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 09:00:38 PST 2020


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

lgtm with a nit, and @dstenb's comment addressed.



================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:690
+  /// In addition to \p isCandidateForCallSiteEntry(), it checks for call
+  /// instructions inside bundles.
+  bool shouldUpdateCallSiteInfo() const;
----------------
A better description might be: "Returns true if copying, moving, or erasing this instruction requires updating Call Site Info (see \ref copyCallSiteInfo, \ref moveCallSiteInfo, etc)."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74904/new/

https://reviews.llvm.org/D74904





More information about the llvm-commits mailing list