[PATCH] D75036: [DebugInfo] Describe call site values for chains of expression producing instrs

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks, this is really nice work.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:603
+  for (auto Param : DescribedParams) {
+    assert(none_of(I.first->second,
+                   [Param](const FwdRegParamInfo &D) {
----------------
I think it'd aid readability to assign I.first->second to some local reference variable.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:615
+        (Param.Expr->getNumElements() > 0)
+            ? DIExpression::append(Expr, Param.Expr->getElements())
+            : Expr;
----------------
Does this implicitly assert !Expr->isEntryValue()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75036/new/

https://reviews.llvm.org/D75036