[PATCH] D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`

[Benjamin Barenblat via Phabricator via llvm-commits]

bbaren added inline comments.


================
Comment at: lld/test/COFF/start-lib.ll:26
 ; TEST2-NOT: Name: foo
-; TEST2: bar
+; TEST2: {{[[:<:]]bar}}
 ; TEST2-NOT: Name: foo
----------------
jhenderson wrote:
> MaskRay wrote:
> > bbaren wrote:
> > > rupprecht wrote:
> > > > I'm not sure what this is supposed to be. Can it just be `Name: bar`? Ditto for `TEST3-NOT` below
> > > `Name: bar` doesn’t work – the map file contains
> > > 
> > > ```
> > > 00001010 00000000     0                 bar
> > > ```
> > > 
> > > However, @MaskRay’s suggestion below applies here as well. Changed to `{{ }}bar`.
> > Maybe it is clearer to match the full line.
> If that's the format, then the TEST2-NOT lines either side of this line won't work...
> 
> Also, perhaps consider `{{ }}bar{{$}`, since `{{ }}bar` could match somebody with a space in their path before "bar".
Ah, good point. Switched everywhere to `{{ }}symbolName{{$}}`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72360/new/

https://reviews.llvm.org/D72360