[PATCH] D74773: [LLD][Debuginfo] create DWARFContext only once for the same object file.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:2671
     if (Error e = cu->tryExtractDIEsIfNeeded(false)) {
-      error(toString(sec) + ": " + toString(std::move(e)));
+      warn(toString(sec) + ": " + toString(std::move(e)));
       return {};
----------------
avl wrote:
> jhenderson wrote:
> > Seems like a not-really-related change? It's certainly not NFC.
> During this review, it was suggested that debuginfo errors would be reported as warnings, when in lld context. Thus, I set warning handler for DWARFContext _and_ patched related places in lld. 
> 
> originally it was NFC, but yes, now it is not NFC. Would change patch header, thanks.    
Okay. Seems like it should be a separate change though (i.e. one for the DWARFContext call_once stuff, and the other for error->warn).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74773/new/

https://reviews.llvm.org/D74773