[PATCH] D71663: [Coroutines] CoroElide enhancement

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 06:33:41 PST 2020


junparser added a comment.

In D71663#1888271 <https://reviews.llvm.org/D71663#1888271>, @modocache wrote:

> Sorry this review took so long, and thank you for addressing the regression I introduced in D43242 <https://reviews.llvm.org/D43242>!
>
> This patch no longer cleanly applies due to my changes in D71900 <https://reviews.llvm.org/D71900>, but I believe I was able to rebase it correctly in P8200 <https://reviews.llvm.org/P8200>. Based on that I think this looks like a great improvement, thank you!
>
> Do you have commit access now, or would you like me to commit this (once you've updated it to apply cleanly) on your behalf?


Yes , thanks for review the patch.
And I have got the commit access, however, how do I push the patch?  Any hint for first time checkin ? Thank you again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71663/new/

https://reviews.llvm.org/D71663





More information about the llvm-commits mailing list