[PATCH] D71701: [AArch64] Peephole optimization. Merge AND and TST instructions
Pavel Kosov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 26 04:19:22 PST 2020
kpdev42 marked an inline comment as done.
kpdev42 added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/peephole-and-tst.ll:32
+; Usage #2
+; CHECK: and [[DSTREG2:w[0-9]+]]
+; CHECK-NEXT: cmp [[DSTREG1]], [[DSTREG2]]
----------------
SjoerdMeijer wrote:
> Selection DAG isel has basic block scope, so I don't think this will be recognised as another use, and thus this would not be affected by a replaceAllUsesWith call when the transformation kicks in. So, best to move the 2nd use to the same block.
Ouch, mea culpa, fixed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71701/new/
https://reviews.llvm.org/D71701
More information about the llvm-commits
mailing list