[PATCH] D75112: [mlir] NFC: move test/IR/core-ops.mlir to test/Dialect/StandardOps/roundtrip.mlir

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 03:01:01 PST 2020


bondhugula added a comment.

In D75112#1893010 <https://reviews.llvm.org/D75112#1893010>, @ftynse wrote:

> I'll just keep everything in the current state then, feel free to send patches if you want.


There isn't a need to abandon this - it'll be good to know what others think about the names. Since we already have numerous directories under test/Dialect/* and there'll likely be more, it'll be good to come to a consensus on consistent names. For eg., Dialect/QuantOps/ has all kinds of 'parse' prefixed parse-*.mlir names. Having different styles is worse here than less accurate names. I'm happy of course to send a patch too once there is consensus.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75112/new/

https://reviews.llvm.org/D75112





More information about the llvm-commits mailing list