[PATCH] D75042: [LLD][ELF][ARM] Implement Thumb pc-relative relocations for adr and ldr

Wed Feb 26 02:50:34 PST 2020

psmith marked an inline comment as done.
psmith added inline comments.

================
Comment at: lld/test/ELF/arm-thumb2-adr.s:21
+ .section .rodata.low, "a", %progbits
+dat1:
+ .byte 0
----------------
MaskRay wrote:
> Should `dat1` `data2` ... be global?
They don't need to be global as they are in a different section to the adr. The assembler can only resolve an adr if the destination is in the same section. Happy to change it if you prefer.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75042/new/

https://reviews.llvm.org/D75042