[PATCH] D75112: [mlir] NFC: move test/IR/core-ops.mlir to test/Dialect/StandardOps/roundtrip.mlir

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 02:34:37 PST 2020


bondhugula added a comment.

In D75112#1892979 <https://reviews.llvm.org/D75112#1892979>, @ftynse wrote:

> I would rather rename the other tests for consistency, suboptimal choices of the past should not define the policy. Tests in Linalg and LLVM are called roundtrip because they test roundtrip of types and arguments as well, which are, obviously, not ops.


Types, arguments, attributes are all attached to / in conjunction with ops; I'd rather rename roundtrip.mlir -> op.mlir at those two inconsistent places. It's roundtrip.mlir that I find both less accurate and inconsistent, and this is adding to the inconsistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75112/new/

https://reviews.llvm.org/D75112





More information about the llvm-commits mailing list